feat(versionable): impl Versionize for Vec<Vec<T>>
#1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/versionize_vec_vec
branch
from
1965a01 to
4a04c39
Compare
tmontaigu
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/749
PR content/description
The versioning of Vec has a shortcut for rust native type (that implement
NotVersioned). The goal of this shortcut is to avoid to do call "versionize" on each element of an integer vector and clone it.This is implemented via the
VersionizeVectrait.VersionizeVechas a blanket impl forT: NotVersionedbut should be manually implemented for other types.The
#[derive(Versionize)]proc macro implements it, but it was not implemented forVec<T>. Due to the "conflicting implementation" rule of the rust compiler, this is at the price of the shortcut impl forVec<Vec<T: NotVersioned>>