Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): do not unwrap in blocks_of, to have the same behavior as the CPU #1622

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore(gpu): do not unwrap in blocks_of, to have the same behavior as the CPU #1622

merged 1 commit into from
Oct 3, 2024

Conversation

agnesLeroy
Copy link
Contributor

@agnesLeroy agnesLeroy commented Oct 3, 2024 •
edited
Loading

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/766

PR content/description

I realized we unwrap in blocks_of for the Cuda compression, which causes the user doc example for compression to fail on GPU.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@agnesLeroy agnesLeroy requested a review from tmontaigu October 3, 2024 07:43
@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@agnesLeroy agnesLeroy merged commit 123c764 into main Oct 3, 2024
139 of 142 checks passed
@agnesLeroy agnesLeroy deleted the al/fix_compression branch October 3, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontaigu tmontaigu tmontaigu approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agnesLeroy @tmontaigu