chore(all): enforce polynomial size to be a power of 2 #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeul-zama
force-pushed
the
mz/enforce_polynomial
branch
from
bc3c778 to
6a4f74a
Compare
IceTDrinker
requested changes
Oct 4, 2024
|
Documenting the function to indicate it’s the floor log2 like the rust std lib is simpler here, I don’t think an assert would make sense, until we have other polynomial rings I don’t think this change is worthwhile |
mayeul-zama
force-pushed
the
mz/enforce_polynomial
branch
from
6a4f74a to
c4785f7
Compare
IceTDrinker
reviewed
Oct 9, 2024
Comment on lines
140
to
143
| /// If the polynomial size is not a power of 2, returns the ceil of its log2 | ||
| pub fn log2(&self) -> PolynomialSizeLog { | ||
| PolynomialSizeLog((self.0 as f64).log2().ceil() as usize) | ||
| } |
There was a problem hiding this comment.
🤔 let's update this function to return "just" the log2 and have a ceil_ilog2 that returns the ceiling log2
also ceil_ilog2 should be written similar to the UnsignedInteger trait:
fn ceil_ilog2(self) -> u32 {
// ilog2 returns the rounded down log2
self.ilog2() + u32::from(!self.is_power_of_two())
}tfhe/src/core_crypto/commons/numeric/unsigned.rs:94 and following
There was a problem hiding this comment.
Let's not have ceil_ilog2 at all then
mayeul-zama
force-pushed
the
mz/enforce_polynomial
branch
from
c4785f7 to
99410ea
Compare
mayeul-zama
force-pushed
the
mz/enforce_polynomial
branch
from
99410ea to
1990876
Compare
IceTDrinker
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.