Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add firefox support for wasm tests and benchmarks #1639

Merged
merged 1 commit into from
Oct 9, 2024
Merged

chore(ci): add firefox support for wasm tests and benchmarks #1639

merged 1 commit into from
Oct 9, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Oct 7, 2024

No description provided.

@soonum soonum added the ci label Oct 7, 2024
@soonum soonum requested a review from IceTDrinker October 7, 2024 08:39
@soonum soonum self-assigned this Oct 7, 2024
@cla-bot cla-bot bot added the cla-signed label Oct 7, 2024
@soonum soonum marked this pull request as draft October 7, 2024 08:39
@soonum soonum force-pushed the dt/ci/firefox_support branch from 8f8f0c4 to cd4ac78 Compare October 7, 2024 09:10
@soonum soonum marked this pull request as ready for review October 7, 2024 09:10
IceTDrinker
IceTDrinker reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing

.github/workflows/benchmark_wasm_client.yml Outdated Show resolved Hide resolved
@soonum soonum force-pushed the dt/ci/firefox_support branch from cd4ac78 to 8dcddb4 Compare October 8, 2024 14:32
@soonum soonum requested a review from IceTDrinker October 8, 2024 14:33
IceTDrinker
IceTDrinker approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright let's try this, do you have a backlog issue for updating Selenium and reducing the stdout spam ?

@soonum soonum merged commit cd36ac5 into main Oct 9, 2024
87 of 88 checks passed
@soonum soonum deleted the dt/ci/firefox_support branch October 9, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees

@soonum soonum

Labels
approved ci cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soonum @IceTDrinker @zama-bot