Ns/versionize transparent #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/versionize_transparent
branch
from
96e9c9e to
614e6b3
Compare
nsarlin-zama
force-pushed
the
ns/versionize_convert_with_bounds
branch
from
8cfa7b7 to
a17dae3
Compare
nsarlin-zama
force-pushed
the
ns/versionize_transparent
branch
3 times, most recently
from
4a97a29 to
0604b27
Compare
tmontaigu
reviewed
Oct 8, 2024
nsarlin-zama
force-pushed
the
ns/versionize_transparent
branch
from
0604b27 to
9312662
Compare
tmontaigu
approved these changes
Oct 8, 2024
nsarlin-zama
force-pushed
the
ns/versionize_transparent
branch
from
9312662 to
9dc7e3f
Compare
IceTDrinker
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/747#issue-2550479942
PR content/description
Add support for
#[repr(transparent)]in the Versionize proc macro. This will skip the versioning of this type by versioning the inner type instead, similar to serde.In this pr I also removed some manual implementations of Versionize that were no longer needed.
Check-list: