Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix firefox wasm benchmarks with new aws ami #1683

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Oct 15, 2024

Some libs were missing to be able to run Firefox out of the box. Besides, action runner is now installed as ubuntu user since Firefox is not able to run as root.

@soonum soonum added the ci label Oct 15, 2024
@soonum soonum requested a review from IceTDrinker October 15, 2024 10:35
@soonum soonum self-assigned this Oct 15, 2024
@cla-bot cla-bot bot added the cla-signed label Oct 15, 2024
@soonum soonum force-pushed the dt/ci/runner_as_user branch from 1033259 to 819ba00 Compare October 15, 2024 10:54
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have a failure with the wasm tests because of the docker run with the pkg being owned by root, so this looks good for the benchmarks but we may need to fix the CPU WASM tests

@soonum soonum force-pushed the dt/ci/runner_as_user branch from 819ba00 to 25afabf Compare October 15, 2024 12:32
@zama-bot zama-bot removed the approved label Oct 15, 2024
@soonum soonum force-pushed the dt/ci/runner_as_user branch from 25afabf to 27ba964 Compare October 15, 2024 12:53
Some libs were missing to be able to run Firefox out of the box.
Besides, action runner is now installed as ubuntu user since
Firefox is not able to run as root.
@soonum soonum force-pushed the dt/ci/runner_as_user branch from 27ba964 to 9fb31db Compare October 15, 2024 13:27
@soonum
Copy link
Contributor Author

soonum commented Oct 15, 2024

We may have a failure with the wasm tests because of the docker run with the pkg being owned by root, so this looks good for the benchmarks but we may need to fix the CPU WASM tests

Issues are fixed now 🎉

@soonum soonum requested a review from IceTDrinker October 15, 2024 13:28
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@soonum soonum merged commit 483a4fe into main Oct 16, 2024
87 checks passed
@soonum soonum deleted the dt/ci/runner_as_user branch October 16, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants