fix(serialization): serialized_size_limit includes the header #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/fix_serialized_size_limit
branch
from
7507873 to
a39931c
Compare
mayeul-zama
reviewed
Oct 18, 2024
nsarlin-zama
force-pushed
the
ns/fix_serialized_size_limit
branch
from
a39931c to
bb205fd
Compare
nsarlin-zama
force-pushed
the
ns/fix_serialized_size_limit
branch
from
bb205fd to
52c48a7
Compare
nsarlin-zama
force-pushed
the
ns/fix_serialized_size_limit
branch
from
52c48a7 to
b82e37a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/794
PR content/description
The user provided serialized size limit did not include the header during serialization, and an upper bound of the header during de-serialization. The size is now always the complete serialized size, header included.
This PR also includes a fix with unlimited size: we used 0 as an unlimited size value, which did not work with bincode.
Check-list: