Ns/backport/fix serialized size #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeul-zama
reviewed
Oct 21, 2024
| @@ -508,7 +608,7 @@ mod test_shortint { | |||
|
|
|||
| let mut buffer = vec![]; | |||
|
|
|||
| let config = SerializationConfig::new(1 << 20).disable_versioning(); | |||
| let config = SerializationConfig::new_with_unlimited_size().disable_versioning(); | |||
There was a problem hiding this comment.
Why have unlimited size here?
There was a problem hiding this comment.
the goal of the test is just to check the deserialization when I give exactly the size of the buffer as a limit (which was failing before), so I don't really care about the serialization size limit.
Since it does not really matter I could have left it with the original size anyways, but since it is a backport I think we should stick with what has been merged to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.