chore(backward): use the Deprecated type from tfhe-versionable #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see failed cargo builds |
nsarlin-zama
force-pushed
the
ns/use_versionable_deprecated
branch
from
ccf452c to
de731cc
Compare
fixed ! |
IceTDrinker
reviewed
Oct 22, 2024
nsarlin-zama
force-pushed
the
ns/use_versionable_deprecated
branch
from
de731cc to
0e63600
Compare
IceTDrinker
reviewed
Oct 23, 2024
Comment on lines
10
to
11
| const TYPE_NAME: &'static str = "SeededLwePackingKeyswitchKey"; | ||
| const MIN_SUPPORTED_APP_VERSION: &'static str = "TFHE-rs v0.8"; |
nsarlin-zama
force-pushed
the
ns/use_versionable_deprecated
branch
from
0e63600 to
60e2021
Compare
IceTDrinker
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR content/description
Use the
Deprecatedtype fromtfhe-versionablefor all the deprecated versions. This removes a bit of code in the backward_compat folders and will improve the error messages because most errors should happen at deserialization, before the call to the "upgrade" method.Sadly the
Deprecabletrait for the types that have deprecated versions is a bit hard to implement with a declarative macro, because the macro needs to handle types with generics (especially with "nested" generics like<Scalar: UnsignedInteger, C: Container<Element = Scalar>>). I think it would require a proc-macro, but I don't know if its worth the price for a few impl (And I think it would be the same thing with impl ofNamed)