chore(scope): no longer check macOS version #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
force-pushed
the
tm/no-check-enclave
branch
from
b9078e2 to
ddb475b
Compare
We checked the macOS version to be sure that the SecRandomCopyBytes was available. Since rust 1.74 (which is older than our current msrv) rust only supports macOS >= 10.12, thus we can expect SecRandomCopyBytes to always be available and can remove the check
tmontaigu
force-pushed
the
tm/no-check-enclave
branch
from
ddb475b to
aa3ce31
Compare
IceTDrinker
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We checked the macOS version to be sure that the
SecRandomCopyBytes was available.
Closes https://github.com/zama-ai/tfhe-rs-internal/issues/806