feat(capi): add mechanism to get panic message as const char * #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
force-pushed
the
tm/c-api-error
branch
6 times, most recently
from
eec75e0 to
7f4bce9
Compare
IceTDrinker
reviewed
Nov 7, 2024
IceTDrinker
reviewed
Nov 7, 2024
Doesn't hurt to have one |
tmontaigu
force-pushed
the
tm/c-api-error
branch
from
7f4bce9 to
d956a72
Compare
Previously, when an error occurred in the rust side, the panic message would get printed to stderr, then the c function would return 1 to indicate error. This commit adds the ability to disable the automatic prints of panic messages and adds functions to get the panic message as a const char * to allow user better control on how to display error messages.
tmontaigu
force-pushed
the
tm/c-api-error
branch
from
d956a72 to
8e1c1c3
Compare
IceTDrinker
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an error occurred in the rust side, the panic message
would get printed to stderr, then the c function would return 1 to
indicate error.
This commit adds the ability to disable the automatic prints of panic
messages and adds functions to get the panic message as a const char *
to allow user better control on how to display error messages.