chore(bench): add throughput for integer benchmarks #1741
Conversation
tfhe/benches/utilities.rs
Outdated
| /// Generate a number of threads to use to saturate current machine for throughput measurements. | ||
| pub fn throughput_num_threads() -> u64 { | ||
| let num_threads = rayon::current_num_threads() as f64; | ||
| // Add 20% more to maximum threads available. | ||
| (num_threads + (num_threads * 0.2)) as u64 | ||
| } |
There was a problem hiding this comment.
unclear this is enough, check with @tmontaigu probably
There was a problem hiding this comment.
Yes its unclear to know if its enough, for some ops it might for others not, or it could be enough for all,
I think a manual check needs to be done by running and trying different values and see if the throughput drastically changes
There was a problem hiding this comment.
did we do any manual checks ?
|
We'll need also to add throughput benches for the GPU 🙂 |
Yes for sure, I just wanted to check for the design before deploying to all the functions. |
soonum
force-pushed
the
dt/bench/throughput
branch
from
e16e88c to
f20e6e7
Compare
|
@soonum I see commits not having the right format it seems and a failing build, should I still review ? |
Yes, please review now. I'll squash all the commits after this first review. |
| if stat_name == "mean" and bench_type == BenchType.throughput: | ||
| value = (elements * ONE_SECOND_IN_NANOSECONDS) / value |
There was a problem hiding this comment.
what is the units of value on the right here ?
There was a problem hiding this comment.
It's operations per second.
There was a problem hiding this comment.
the value after the / sign ?
There was a problem hiding this comment.
It's the value in nanoseconds recorded by criterion.
There was a problem hiding this comment.
and elements ?
it's unclear by looking at the formula if this si correct
There was a problem hiding this comment.
we are rescaling the nanosecond measurement to seconds ?
There was a problem hiding this comment.
Yes to display elements / second
soonum
force-pushed
the
dt/bench/throughput
branch
6 times, most recently
from
fae1e07 to
d375ed2
Compare
soonum
force-pushed
the
dt/bench/throughput
branch
from
d375ed2 to
dd5e944
Compare
| if bench_type == BenchType.throughput and elements is None: | ||
| # Current subdir contains only latency measurements | ||
| continue |
soonum
force-pushed
the
dt/bench/throughput
branch
3 times, most recently
from
13ba2ee to
58b248c
Compare
soonum
force-pushed
the
dt/bench/throughput
branch
from
58b248c to
cdb34ba
Compare
soonum
force-pushed
the
dt/bench/throughput
branch
2 times, most recently
from
b35932e to
474695e
Compare
soonum
force-pushed
the
dt/bench/throughput
branch
7 times, most recently
from
f40bb4b to
7857afc
Compare
All integer benchmarks make recipes can be run to ouput throughput results. Only CPU is supported for throughput benchmarks in GitHub CI.
soonum
force-pushed
the
dt/bench/throughput
branch
from
7857afc to
8ab150a
Compare
No description provided.