Ns/zk curve conformance #1743
Merged
Ns/zk curve conformance #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/zk_curve_conformance
branch
2 times, most recently
from
ff58f71 to
123251d
Compare
mayeul-zama
reviewed
Nov 4, 2024
IceTDrinker
reviewed
Nov 4, 2024
nsarlin-zama
force-pushed
the
ns/zk_curve_conformance
branch
from
123251d to
ba7b7a5
Compare
nsarlin-zama
force-pushed
the
ns/zk_curve_conformance
branch
from
ba7b7a5 to
bf57764
Compare
IceTDrinker
requested changes
Nov 6, 2024
nsarlin-zama
force-pushed
the
ns/zk_curve_conformance
branch
from
bf57764 to
646181c
Compare
IceTDrinker
approved these changes
Nov 6, 2024
nsarlin-zama
force-pushed
the
ns/zk_curve_conformance
branch
from
646181c to
0cf5de0
Compare
nsarlin-zama
force-pushed
the
ns/zk_curve_conformance
branch
from
0cf5de0 to
6773a79
Compare
nsarlin-zama
force-pushed
the
ns/zk_curve_conformance
branch
from
6773a79 to
7befd57
Compare
|
@IceTDrinker if you could just validate the workflow/Makefile part of the last commit (I rebased so looking at the commit will be easier) |
IceTDrinker
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/zama-ai/tfhe-rs-internal/issues/744
Adds conformance for zk proof and crs.
Proof conformance checks that the points are on the curve and in the correct subgroup.
Crs conformance also checks that the crs is valid for the parameters.