fix(zk): fix build with feature zk-pok without shortint #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Nov 7, 2024
Makefile
Outdated
Comment on lines
336
to
344
| .PHONY: clippy_zk # Run clippy lints on TFHE-rs with the zk-pok feature enabled | ||
| clippy_zk: install_rs_check_toolchain | ||
| RUSTFLAGS="$(RUSTFLAGS)" cargo "$(CARGO_RS_CHECK_TOOLCHAIN)" clippy \ | ||
| --features=$(TARGET_ARCH_FEATURE),zk-pok \ | ||
| -p $(TFHE_SPEC) -- --no-deps -D warnings | ||
| RUSTFLAGS="$(RUSTFLAGS)" cargo "$(CARGO_RS_CHECK_TOOLCHAIN)" clippy \ | ||
| --features=$(TARGET_ARCH_FEATURE),zk-pok,shortint \ | ||
| -p $(TFHE_SPEC) -- --no-deps -D warnings | ||
|
|
There was a problem hiding this comment.
check clippy_zk_pok maybe ? or choose a name a bit more different
There was a problem hiding this comment.
clippy_zk_pok is already used for clippy on the tfhe-zk-pok crate...
nsarlin-zama
force-pushed
the
ns/fix_build_zk_no_shortint
branch
from
48d90be to
12b52a7
Compare
IceTDrinker
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.