Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gpu): Implement abs operation on gpu backend #1777

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(gpu): Implement abs operation on gpu backend #1777

merged 1 commit into from
Nov 15, 2024

Conversation

bbarbakadze
Copy link
Contributor

PR content/description

Implements abs operation in GPU backend.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Nov 13, 2024
agnesLeroy
agnesLeroy reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bbarbakadze! Thanks a lot for this PR, here comes my review, some little changes to make but overall it looks good.

tfhe/src/integer/gpu/server_key/radix/abs.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/abs.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/abs.rs Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/abs.rs Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/abs.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/abs.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/abs.rs Outdated Show resolved Hide resolved
tfhe/src/lib.rs Outdated Show resolved Hide resolved
@agnesLeroy
Copy link
Contributor

@guillermo-oyarzun probably this PR will get merged before yours, it uses single carry prop so it'll have to be refactored.

@bbarbakadze bbarbakadze force-pushed the feat/cuda/abs branch 2 times, most recently from cad3171 to 529bc74 Compare November 14, 2024 14:32
@zama-bot zama-bot removed the approved label Nov 15, 2024
@agnesLeroy agnesLeroy merged commit 0aee4c5 into main Nov 15, 2024
86 of 91 checks passed
@agnesLeroy agnesLeroy deleted the feat/cuda/abs branch November 15, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbarbakadze @agnesLeroy @zama-bot