fix(hlapi): rework CompressedCiphertextListBuilder #1793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hlapi builder target device was selected depending on features (gpu enabled ? gpu : cpu), but if at
build
time the thread_local key did not match the expected device, an error would be returned.This is a bit too limiting for users that might want to do some processing on GPU and compression on CPU.
So the Builder is changed to delay, the selection of device used to compress when
build
is called.This new design is more flexible for end users, at the cost of a bit more memory copies
(which is not serializable) has been changed