Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): update multi-bit params, add noise test for the classical & multi-bit PBS #1895

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore(gpu): update multi-bit params, add noise test for the classical & multi-bit PBS #1895

merged 1 commit into from
Jan 6, 2025

Conversation

agnesLeroy
Copy link
Contributor

@agnesLeroy agnesLeroy commented Dec 18, 2024 •
edited
Loading

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Dec 18, 2024
@agnesLeroy agnesLeroy changed the title chore(gpu): update multi-bit params, add noise test for the classical… chore(gpu): update multi-bit params, add noise test for the classical & multi-bit PBS Dec 19, 2024
@agnesLeroy agnesLeroy force-pushed the al/noise_test branch 3 times, most recently from 4d79c6a to 59fd6e7 Compare December 19, 2024 17:39
@agnesLeroy agnesLeroy requested a review from IceTDrinker January 6, 2025 10:20
IceTDrinker
IceTDrinker reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small things I noted for the minimal variance for security with TUniform distribution this looks good to me

@agnesLeroy agnesLeroy requested a review from IceTDrinker January 6, 2025 13:37
@agnesLeroy agnesLeroy force-pushed the al/noise_test branch 2 times, most recently from 4c30fea to 2370a66 Compare January 6, 2025 15:54
@agnesLeroy agnesLeroy merged commit 33ca2c2 into main Jan 6, 2025
101 of 103 checks passed
@agnesLeroy agnesLeroy deleted the al/noise_test branch January 6, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @IceTDrinker @zama-bot