Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gpu): implement vector comparisons gpu #1900

Merged

Conversation

guillermo-oyarzun
Copy link
Member

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@guillermo-oyarzun guillermo-oyarzun self-assigned this Dec 20, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 20, 2024
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-vector-comparison-gpu-rebased branch from b25a448 to 4f0caef Compare December 20, 2024 09:52
@bbarbakadze
Copy link
Contributor

Great work, thanks.

@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-vector-comparison-gpu-rebased branch from 4f0caef to 71116d8 Compare December 23, 2024 12:23
@zama-bot zama-bot removed the approved label Dec 23, 2024
@guillermo-oyarzun
Copy link
Member Author

So, I have manually run unsigned, signed and multi-gpu tests, all are passing.

@guillermo-oyarzun guillermo-oyarzun merged commit cd03b7e into main Dec 23, 2024
101 of 111 checks passed
@guillermo-oyarzun guillermo-oyarzun deleted the go/feature/implement-vector-comparison-gpu-rebased branch December 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants