Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper upload_to_s3 error messaging #1316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lmuther8
Copy link
Contributor

@lmuther8 lmuther8 commented Mar 29, 2024

Description

New Behavior
The zappa update {{stage}} call should error out and alert the user they cannot access the bucket they are trying to.

Old Behavior
The zappa update {{stage}} continues and creates a new s3 bucket or errors out because the does not have permission to create a new S3 bucket.

GitHub Issues

Closes #1315

Copy link
Collaborator

@monkut monkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a testcase for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zappa tries to create new S3 bucket when it can't access the already existing one
2 participants