feat: improve lib type inference for SRA PE samples #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_evaluate_mate_relationship
for library type relationship inference to align samples when two input files are given but both are deemedsingle
first_mate_assumed
andsecond_mate_assumed
, when the relationship is determined to besplit_mates
, refactor_update_relationship_type
helper function to assign states typeslib_type_mates_cutoff
to 0.85 based on results from feat: improve lib type relationship inference for SRA samples #160Closes #160
Type of change
Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.
warnings
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
methods/functions or updated previously existing ones
works
reduced the code coverage relative to the previous state
by the proposed changes
If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.