Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve lib type inference for SRA PE samples #161

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

balajtimate
Copy link
Collaborator

Description

  • Expand _evaluate_mate_relationship for library type relationship inference to align samples when two input files are given but both are deemed single
  • Add additional library type states first_mate_assumed and second_mate_assumed, when the relationship is determined to be split_mates, refactor _update_relationship_type helper function to assign states types
  • Update tests
  • Lower lib_type_mates_cutoff to 0.85 based on results from feat: improve lib type relationship inference for SRA samples #160

Closes #160

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b65c43) 100.00% compared to head (241a47c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1131      1143   +12     
=========================================
+ Hits          1131      1143   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balajtimate balajtimate requested a review from uniqueg January 23, 2024 10:46
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@balajtimate balajtimate merged commit 69ea74c into dev Jan 23, 2024
21 checks passed
@balajtimate balajtimate deleted the add_assumed_mates branch January 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve lib type relationship inference for SRA samples
2 participants