Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: create data package #163

Merged
merged 1 commit into from
Feb 5, 2024
Merged

build: create data package #163

merged 1 commit into from
Feb 5, 2024

Conversation

balajtimate
Copy link
Collaborator

Description

  • Add __init__.py to data directory, to mark is as subpackage and include it in conda builds
  • Update versioning in htsinfer/__init__.py

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e100d72) 100.00% compared to head (a49c263) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1143      1143           
=========================================
  Hits          1143      1143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balajtimate
Copy link
Collaborator Author

There's a temporary issue with coverage, but the unit tests run normally, the report just cannot be submitted.

@balajtimate balajtimate requested a review from uniqueg February 5, 2024 14:43
@uniqueg
Copy link
Member

uniqueg commented Feb 5, 2024

Yeah, I had the same. Annoying 😅

@uniqueg uniqueg changed the title feat: add __init__.py to data build: create data package Feb 5, 2024
@uniqueg uniqueg enabled auto-merge (squash) February 5, 2024 16:51
@uniqueg uniqueg merged commit a86cc09 into dev Feb 5, 2024
19 checks passed
@uniqueg uniqueg deleted the fix_data_dir branch February 5, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants