Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: update regex for seqid #166

Merged
merged 1 commit into from
May 15, 2024
Merged

perf: update regex for seqid #166

merged 1 commit into from
May 15, 2024

Conversation

balajtimate
Copy link
Collaborator

Description

  • Update regex to match seqID's with Casava >= 1.8 format, if there's a dash in the ID

Fixes #165

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (50e6d84) to head (7901baf).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1143      1143           
=========================================
  Hits          1143      1143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balajtimate balajtimate requested a review from uniqueg May 15, 2024 07:52
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pleasure to review your PRs 😅

@balajtimate balajtimate merged commit 51957ac into dev May 15, 2024
21 checks passed
@balajtimate balajtimate deleted the update_states branch May 15, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: seqid with dash not matching regex
2 participants