Implements feature to stream pod logs in Loki #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxiomSamarth
commented
Oct 8, 2022
| @@ -53,15 +58,21 @@ func runRun() error { | |||
| return err | |||
| } | |||
|
|
|||
| err = rr.Run(context.Background()) | |||
| cancelCtx, cancelFunc := context.WithTimeout(context.Background(), runOpts.streamDuration) | |||
There was a problem hiding this comment.
I have created this new context with the timeout set to stream-duration value which is used across the methods & functions here.
internal/runner/runner.go
Outdated
| labels["container_name"] = container.Name | ||
| // streamPodLogs will stream the pod logs and load the logs to loki with relevant | ||
| // labels, loglines and timestamp | ||
| func (r *runner) streamPodLogs(cancelCtx context.Context, cs kubernetes.Interface, pod corev1.Pod) error { |
There was a problem hiding this comment.
@zawachte I want to know if I can utilize the cancelCtx here to return cancelCtx.Done() when the context deadline is exceeded when streamPodLogs is called. I am still catching up with the goroutine channels aspect. Is there any suggestions you have for me to handle this better?
AxiomSamarth
commented
Oct 8, 2022
internal/runner/runner.go
Outdated
| reader.Split(bufio.ScanLines) | ||
| defer stream.Close() | ||
|
|
||
| for reader.Scan() { |
There was a problem hiding this comment.
because the Follow attribute in the podLogOptions has been set to true, this reader.Scan() will always be true and reads continuously (and hence can be used as infinite loop and reader too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to stream the pod logs in Loki to address issue #1
As goroutines are employed to stream the pod logs, to keep them active, we need to ensure that the
maindoesn't terminate. Hence, a new flagstream-durationis newly introduced. This will keepmainactive and the streaming will continue for a duration as set bystream-duration. Default value ofstream-durationis set to 1 hour.