Check this please~ #265
Open
Check this please~ #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devjoylee
commented
Jan 11, 2021
zaydek
requested changes
Jan 11, 2021
src/runtime/runtime.ts
Outdated
| @@ -144,6 +178,12 @@ class Duomo implements Runtime { | |||
| return this.#darkMode | |||
| } | |||
| setDarkMode(mode: boolean) { | |||
| const durValue = getComputedStyle(document.documentElement).getPropertyValue('--default-theme-transition-duration'); | |||
|
|
|||
| if(this.#shouldNoOpDarkMode){ | |||
There was a problem hiding this comment.
Make sure you’re using Prettier if you’re not already. I would expect this to be if (this.#shouldNoOpDarkMode) { (you have no spaces right now).
There was a problem hiding this comment.
I installed the Prettier, but It's still same. Probably prettier setting problem on my vscode..
zaydek
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.