Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(panel): avoid being stuck "loading" #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(panel): avoid being stuck "loading" #335

wants to merge 1 commit into from

Commits on Nov 5, 2024

  1. fix(panel): avoid being stuck "loading" 

    Whenever the Copilot LSP knows it's not going to provide any
suggestions, it replies with PanelSolutionsDone even before it completes
the request. This resulted in us setting the status to "done" and then
immediately resetting it to "loading", and thus getting stuck on
"loading".

The fix is to set the status to "loading" in the initial refresh call
itself to avoid the race between on_solutions_done and the
get_panel_completions callback.
    @liskin
    liskin committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    55c09b0 View commit details
    Browse the repository at this point in the history