This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
forked from valora-inc/wallet
-
Notifications
You must be signed in to change notification settings - Fork 2
@osdnk/t #119
Open
osdnk
wants to merge
97
commits into
zed-io:develop
Choose a base branch
from
capsule-org:@osdnk/t
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
@osdnk/t #119
Commits on Nov 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a68a43b - Browse repository at this point
Copy the full SHA a68a43bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 531e5b4 - Browse repository at this point
Copy the full SHA 531e5b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e616fdc - Browse repository at this point
Copy the full SHA e616fdcView commit details
Commits on Nov 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dfc28e3 - Browse repository at this point
Copy the full SHA dfc28e3View commit details
Commits on Nov 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 41e59ce - Browse repository at this point
Copy the full SHA 41e59ceView commit details
Commits on Dec 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 591ed79 - Browse repository at this point
Copy the full SHA 591ed79View commit details
Commits on Dec 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8688f22 - Browse repository at this point
Copy the full SHA 8688f22View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7b4a8b - Browse repository at this point
Copy the full SHA a7b4a8bView commit details
Commits on Dec 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1ea9e30 - Browse repository at this point
Copy the full SHA 1ea9e30View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9fd0b5 - Browse repository at this point
Copy the full SHA e9fd0b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44f386d - Browse repository at this point
Copy the full SHA 44f386dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 123edb5 - Browse repository at this point
Copy the full SHA 123edb5View commit details
Commits on Dec 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dda9b5b - Browse repository at this point
Copy the full SHA dda9b5bView commit details
Commits on Dec 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6bbddf5 - Browse repository at this point
Copy the full SHA 6bbddf5View commit details
Commits on Dec 14, 2022
-
Co-authored-by: codyborn <codyborn@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for 2390e42 - Browse repository at this point
Copy the full SHA 2390e42View commit details
Commits on Dec 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f7ea3ac - Browse repository at this point
Copy the full SHA f7ea3acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99e91a7 - Browse repository at this point
Copy the full SHA 99e91a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2648964 - Browse repository at this point
Copy the full SHA 2648964View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4e527f - Browse repository at this point
Copy the full SHA f4e527fView commit details
Commits on Dec 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9eec2f3 - Browse repository at this point
Copy the full SHA 9eec2f3View commit details
Commits on Dec 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c96deee - Browse repository at this point
Copy the full SHA c96deeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdf5134 - Browse repository at this point
Copy the full SHA bdf5134View commit details
Commits on Dec 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4de1fa9 - Browse repository at this point
Copy the full SHA 4de1fa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28fd364 - Browse repository at this point
Copy the full SHA 28fd364View commit details
Commits on Jan 2, 2023
-
Persisting across session / foundation for Keychain support (#6)
## Overview This PR includes changes relating to storing private shares and signers in the Async Storage. I decided to put the storing logic inside the `Wallet` entity. This is a different solution that is known from other wallets, but I believe this is a reasonable approach here because, together with signers and shares, we will also introduce biometric storage. Therefore, we have a bit more data to store and we should not rely on wallets to integrate with every storage properly. I decided to make the approach modular. I decided to create abstract classes for a different type of storage (for private keys and for signers) and immediately follow up with an opinionated implementation tailored for React Native. However, from the user's perspective, that is perfectly fine to replace our implementation with any other, better suited for the product. ### Signers storage That is the store with public information about signers connected with the given account. Those are stored in the Local Storage, being a default (although maybe suboptimal) solution for React Native Projects. ### Private keys storage That is the storage, which is designed to include sensitive information. Namely, we store private shares (secp256k1 shards), which should be hidden under some security measures. Temporarily, I did that also with Local Storage, which is _the wrong_ solution. However, I did it to avoid dealing with the technicalities of native code with accessing the keychain. If that PR is approved and we will have 100% confidence around every piece of the architecture, we will proceed with purely technical work of migrating those data into secure storage. ### `CapsuleReactNativeWallet` and `CapsuleBaseWallet`. That is purely aesthetical change, but it's worth motivating. Since we are not opinionated toward any storage implementation and allow for replacing our implementations and predicting support for different platforms, we extracted out RN-related components. We created the `CapsuleBaseWallet` abstract class with some methods (RN-specific) implemented in the class `CapsuleReactNativeWallet`. ### `BiometricSessionManager` Biometrics-related things were extracted out with opinionated stuff moved to `CapsuleReactNativeWallet` ## Testing In order to test it, please navigate to `contracts.ts` and uncomment `await testSigning(newWallet)`. After opening the app for the second time, it should be possible to sign the transaction immediately (and see the output in the terminal)
Configuration menu - View commit details
-
Copy full SHA for d4e84e2 - Browse repository at this point
Copy the full SHA d4e84e2View commit details -
Create a fake flow to create a new user (#8)
## Motivation Now, we need to migrate from a hardcoded user-id to a generic mechanism. ## Changes First, note that we created a workaround to accept any code to verify a user whose email ends with `@test.usecapsule.com`. We did it to replicate the flow of creating users in the Kolektive without the tedious (and pointless) work of creating temporary react components for inputting email and verification codes. Obviously, this will need to change while making a real integration. Similarly, as in #6 and #7, I added an extra abstract method to be implemented in an actual wallet class and provided a default implementation for React Native which relies (again) on `AsynsStorage`. We assume that we can access the correct user-id before initiating the wallet instance. Similarly, our decision and design can be easily altered with overring methods. ## Cookies We needed to move around a few things to ensure that while initializing sessions manager, we already know the userId
Configuration menu - View commit details
-
Copy full SHA for 293c780 - Browse repository at this point
Copy the full SHA 293c780View commit details
Commits on Jan 4, 2023
-
## Motivation We want to make the complete flow work with cookies refreshing if needed. ## Changes I decided to make a different approach than previously. Before, I was expecting to analyze cookies on the front end; if it's outdated, we renew the cookie and take action. Obviously, on top of that, we still had to prepare the logic to prevent the case if the cookie expired in the meantime and the server rejected us due to cookie expiration. The motivation for that was not to make the request that would certainly fail if we knew upfront that the cookie was expired. However, for the sake of MVP, we are OK with one more request, and I decided to always optimistically try to make a request, and only if the backend rejects the cookie, we make the renewal. That solution is enormously more straightforward because now we avoid all the "manual" cookie parsing, and we can safely rely on built-in React Native logic for cookie manipulation. We don't even directly store the cookie. In the further iteration, we should implement analyzing cookies on the front end. We now have a wrapper for server fetches that automatically renews sessions if the wrapped function fails due to the cookies policy. ~I cannot test it now due to https://capsule-labs.slack.com/archives/C042W1BSG59/p1672606731886599~ To test it, I added a 5 min delay before pre sign of tx to ensure the cookie outdated ` await new Promise((r) => setTimeout(r, 300000))`
Configuration menu - View commit details
-
Copy full SHA for 8329903 - Browse repository at this point
Copy the full SHA 8329903View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e982511 - Browse repository at this point
Copy the full SHA e982511View commit details
Commits on Jan 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 56d531c - Browse repository at this point
Copy the full SHA 56d531cView commit details
Commits on Jan 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ff63b84 - Browse repository at this point
Copy the full SHA ff63b84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 150553b - Browse repository at this point
Copy the full SHA 150553bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b116ab - Browse repository at this point
Copy the full SHA 2b116abView commit details -
Configuration menu - View commit details
-
Copy full SHA for a04ab1a - Browse repository at this point
Copy the full SHA a04ab1aView commit details
Commits on Jan 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e28ffeb - Browse repository at this point
Copy the full SHA e28ffebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99aa12f - Browse repository at this point
Copy the full SHA 99aa12fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d2a52 - Browse repository at this point
Copy the full SHA 24d2a52View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad23b6d - Browse repository at this point
Copy the full SHA ad23b6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c76be04 - Browse repository at this point
Copy the full SHA c76be04View commit details
Commits on Jan 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 65faf9b - Browse repository at this point
Copy the full SHA 65faf9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e23f5aa - Browse repository at this point
Copy the full SHA e23f5aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 567d687 - Browse repository at this point
Copy the full SHA 567d687View commit details
Commits on Jan 18, 2023
-
Merge pull request #15 from capsule-org/cody/SignPersonalMessage
Implement SignPersonalMessage
Configuration menu - View commit details
-
Copy full SHA for a47805b - Browse repository at this point
Copy the full SHA a47805bView commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7cf0a18 - Browse repository at this point
Copy the full SHA 7cf0a18View commit details
Commits on Jan 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 793e8ac - Browse repository at this point
Copy the full SHA 793e8acView commit details -
Configuration menu - View commit details
-
Copy full SHA for c17b404 - Browse repository at this point
Copy the full SHA c17b404View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8674c0f - Browse repository at this point
Copy the full SHA 8674c0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d96d9e5 - Browse repository at this point
Copy the full SHA d96d9e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dfc93e - Browse repository at this point
Copy the full SHA 6dfc93eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d454446 - Browse repository at this point
Copy the full SHA d454446View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 34a35c9 - Browse repository at this point
Copy the full SHA 34a35c9View commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c10d951 - Browse repository at this point
Copy the full SHA c10d951View commit details
Commits on Feb 2, 2023
-
Key Recovery: Capsule Wallet + Signer (#19)
Co-authored-by: osdnk <micosa97@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3fe8ae3 - Browse repository at this point
Copy the full SHA 3fe8ae3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1753c16 - Browse repository at this point
Copy the full SHA 1753c16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d7540b - Browse repository at this point
Copy the full SHA 6d7540bView commit details
Commits on Feb 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ba7ab4f - Browse repository at this point
Copy the full SHA ba7ab4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8fabd - Browse repository at this point
Copy the full SHA ac8fabdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f040e2 - Browse repository at this point
Copy the full SHA 2f040e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50202d2 - Browse repository at this point
Copy the full SHA 50202d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2046b6a - Browse repository at this point
Copy the full SHA 2046b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4d16a4 - Browse repository at this point
Copy the full SHA e4d16a4View commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2e5b784 - Browse repository at this point
Copy the full SHA 2e5b784View commit details
Commits on Feb 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b34f60f - Browse repository at this point
Copy the full SHA b34f60fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c54613 - Browse repository at this point
Copy the full SHA 5c54613View commit details -
Configuration menu - View commit details
-
Copy full SHA for c702e6e - Browse repository at this point
Copy the full SHA c702e6eView commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cb9fb19 - Browse repository at this point
Copy the full SHA cb9fb19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d75137 - Browse repository at this point
Copy the full SHA 0d75137View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94c1a94 - Browse repository at this point
Copy the full SHA 94c1a94View commit details
Commits on Feb 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3c81964 - Browse repository at this point
Copy the full SHA 3c81964View commit details -
Configuration menu - View commit details
-
Copy full SHA for 496295c - Browse repository at this point
Copy the full SHA 496295cView commit details
Commits on Feb 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6f008a3 - Browse repository at this point
Copy the full SHA 6f008a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40fd37a - Browse repository at this point
Copy the full SHA 40fd37aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14ef7e3 - Browse repository at this point
Copy the full SHA 14ef7e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94cc7eb - Browse repository at this point
Copy the full SHA 94cc7ebView commit details
Commits on Feb 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bf430cc - Browse repository at this point
Copy the full SHA bf430ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8879d53 - Browse repository at this point
Copy the full SHA 8879d53View commit details
Commits on Mar 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 678c89c - Browse repository at this point
Copy the full SHA 678c89cView commit details
Commits on Mar 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6dcc454 - Browse repository at this point
Copy the full SHA 6dcc454View commit details
Commits on Apr 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eca7b55 - Browse repository at this point
Copy the full SHA eca7b55View commit details
Commits on Apr 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 711d4c2 - Browse repository at this point
Copy the full SHA 711d4c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d4416d - Browse repository at this point
Copy the full SHA 7d4416dView commit details
Commits on Apr 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fc9d889 - Browse repository at this point
Copy the full SHA fc9d889View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ac73f1 - Browse repository at this point
Copy the full SHA 8ac73f1View commit details
Commits on May 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5ef166c - Browse repository at this point
Copy the full SHA 5ef166cView commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e0a4f4 - Browse repository at this point
Copy the full SHA 7e0a4f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8cec24 - Browse repository at this point
Copy the full SHA f8cec24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aa126d - Browse repository at this point
Copy the full SHA 8aa126dView commit details
Commits on Jun 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 92df2a9 - Browse repository at this point
Copy the full SHA 92df2a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 550b2a3 - Browse repository at this point
Copy the full SHA 550b2a3View commit details
Commits on Jul 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f3c1236 - Browse repository at this point
Copy the full SHA f3c1236View commit details
Commits on Jul 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f90858 - Browse repository at this point
Copy the full SHA 9f90858View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cd42da - Browse repository at this point
Copy the full SHA 2cd42daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73b65eb - Browse repository at this point
Copy the full SHA 73b65ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for b43949b - Browse repository at this point
Copy the full SHA b43949bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a4ebc8 - Browse repository at this point
Copy the full SHA 7a4ebc8View commit details
Commits on Jul 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 57e946b - Browse repository at this point
Copy the full SHA 57e946bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e866f0 - Browse repository at this point
Copy the full SHA 2e866f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0c7250 - Browse repository at this point
Copy the full SHA e0c7250View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.