Fix curator again #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New golden test allows to verify templates from parent chart. Camunda platform helm parent chart might change from time to time unexpectly deployments or even configurations, which can be detected with such test. Furthermore, allows to verify that values are correctly applied.
Image is part of the retention policy, was not correctly indended which causes to not set the repository correctly
Retrieving all templates, doesn't work well with elasticsearch deployments. Names seem to be auto generated. We will test against specific templates at least to ensure stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the values file in order to resolve an issue with the curator image. The image is part of the retention policy but was not correctly indented which causes them to not set the repository correctly. This wrong config causes another benchmark failure. https://camunda.slack.com/archives/CSQ2E3BT4/p1688390901298959
Adds a new golden test that allows for verifying templates from the parent chart.
Camunda platform helm parent chart might change from time to time unexpectedly deployments
or even configurations, which can be detected with such tests. Furthermore, allows us to verify that values are correctly applied.
With this PR we added the first chunk of golden file tests for the parent chart