Skip to content

Commit

Permalink
UDN: Skip adding managementport to clusterPortGrp
Browse files Browse the repository at this point in the history
We kept trying to add the management port
for secondary networks into the cluster
port group of secondary networks.

But that port group doesn't exist yet.
It will exist once we get ovn-org#4547
merged but until then this is causing
infinite retries from syncMgmtPort
erroring out.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
  • Loading branch information
tssurya authored and zeeke committed Oct 22, 2024
1 parent 84417f4 commit 08387ee
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions go-controller/pkg/ovn/base_network_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -680,11 +680,13 @@ func (bnc *BaseNetworkController) syncNodeManagementPort(node *kapi.Node, switch
return nil, err
}

// TODO(dceara): The cluster port group must be per network.
err = libovsdbops.AddPortsToPortGroup(bnc.nbClient, bnc.getClusterPortGroupName(types.ClusterPortGroupNameBase), logicalSwitchPort.UUID)
if err != nil {
klog.Errorf(err.Error())
return nil, err
// TODO(dceara): The cluster port group must be per network. So for now skip adding management port to the cluster port
// group for secondary network's because the cluster port group is not yet created for secondary networks.
if bnc.IsDefault() {
if err = libovsdbops.AddPortsToPortGroup(bnc.nbClient, bnc.getClusterPortGroupName(types.ClusterPortGroupNameBase), logicalSwitchPort.UUID); err != nil {
klog.Errorf(err.Error())
return nil, err
}
}

if v4Subnet != nil {
Expand Down

0 comments on commit 08387ee

Please sign in to comment.