Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extract_assets.py -s modification check #1978

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix extract_assets.py -s modification check #1978

merged 1 commit into from
Jun 26, 2024

Conversation

cadmic
Copy link
Contributor

@cadmic cadmic commented Jun 26, 2024

Previously, the -s flag like in ./extract_assets.py -v gc-us -s overlays/ovl_En_Jsjutan would ignore file modification timestamps and always rebuild, but this got broken by #1967 due to some type confusion (fullPath was a Path but the keys of extractedAssetsTracker are strs).

Dragorn421
Dragorn421 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie

@fig02 fig02 merged commit 93b687e into zeldaret:main Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dragorn421 Dragorn421 Dragorn421 approved these changes

@fig02 fig02 fig02 approved these changes

Assignees
No one assigned
Labels
Needs second approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cadmic @Dragorn421 @fig02