Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent modules #579

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

ffredyk
Copy link
Contributor

@ffredyk ffredyk commented Mar 24, 2021

When merged this pull request will:

  • Add a new parameter to zen_custom_modules_fnc_register for module persistency.
  • Add a condition inside the custom module initialization function to remove only non-persistent modules.

PR for #577

@neilzar neilzar added this to the 1.11.0 milestone Mar 24, 2021
@neilzar neilzar added the enhancement Improves an existing feature label Mar 24, 2021
@mharis001
Copy link
Member

One problem with this is that the module does not have the correct name, category, or icon in the entities tree.

@ffredyk
Copy link
Contributor Author

ffredyk commented Mar 25, 2021

@mharis001 well I am not going to try and implement that kind of UI hacking, so if nobody else is up for the job, you could at least let it slide undercover and not list it publicly as a official supported function. This little change however, will greatly expand custom module possibilities and I personally would not mind the incorrect information inside the entities tree.

@mharis001
Copy link
Member

The module isn't passed as a parameter to the function. Also, if the user code really needs a logic object, it can create one. Need to think more about this.

@mharis001 mharis001 modified the milestones: 1.11.0, Backlog May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants