Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): implementing hono adapter #1739

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat(server): implementing hono adapter #1739

merged 1 commit into from
Sep 30, 2024

Conversation

svetch
Copy link
Contributor

@svetch svetch commented Sep 25, 2024

Fixes #1270

Copy link
Contributor

coderabbitai bot commented Sep 25, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes introduce a new middleware handler for a Hono application, encapsulated in a new file handler.ts. This middleware utilizes a Prisma client for database interactions and includes an interface HonoOptions. Additionally, an index.ts file is created to re-export functionalities from handler.ts. Comprehensive tests for both RPC and REST handlers are added in hono.test.ts, ensuring the correct operation of API endpoints related to user and post management.

Changes

Files Change Summary
packages/server/src/hono/*.ts Introduced a new middleware handler in handler.ts, defining HonoOptions interface and createHonoHandler function. Created index.ts to re-export all entities from the handler module.
packages/server/tests/adapter/hono.test.ts Added a suite of tests for the Hono adapter covering RPC and REST handlers, including functions for creating requests and unmarshalling responses. The tests validate API endpoint functionality for user and post management.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c7fad1e and bb7b7cd.

⛔ Files ignored due to path filters (2)
  • packages/server/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
📒 Files selected for processing (3)
  • packages/server/src/hono/handler.ts (1 hunks)
  • packages/server/src/hono/index.ts (1 hunks)
  • packages/server/tests/adapter/hono.test.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/server/src/hono/handler.ts
  • packages/server/src/hono/index.ts
  • packages/server/tests/adapter/hono.test.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between bfe6983 and 7abf2c2.

🔇 Files ignored due to path filters (2)
  • packages/server/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
📒 Files selected for processing (3)
  • packages/server/src/hono/handler.ts (1 hunks)
  • packages/server/src/hono/index.ts (1 hunks)
  • packages/server/tests/adapter/hono.test.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/server/src/hono/index.ts

packages/server/src/hono/handler.ts Show resolved Hide resolved
packages/server/src/hono/handler.ts Show resolved Hide resolved
packages/server/src/hono/handler.ts Show resolved Hide resolved
packages/server/tests/adapter/hono.test.ts Show resolved Hide resolved
packages/server/tests/adapter/hono.test.ts Outdated Show resolved Hide resolved
packages/server/tests/adapter/hono.test.ts Show resolved Hide resolved
@LilaRest
Copy link

Hey guys! When should we expect the 2.7.0 to be released?

@ymc9
Copy link
Member

ymc9 commented Sep 30, 2024

Hey guys! When should we expect the 2.7.0 to be released?

Hey guys! When should we expect the 2.7.0 to be released?

Hi @LilaRest , I hope around 10/15. The adapter code is actually self contained, so if you are waiting for it, you can copy paste into your code base. When it's released, simply remove the code and import from @zenstackhq/server/hono.

Also, it'll be great if you could help test the code. I'm not experienced with Hono at all 😄

@LilaRest
Copy link

@ymc9 Alright sounds great, thanks! I'll do that way 😄

@ymc9
Copy link
Member

ymc9 commented Sep 30, 2024

@svetch , I think we need to add an export entry for hono in "package.json" file as well.

@svetch
Copy link
Contributor Author

svetch commented Sep 30, 2024

@svetch , I think we need to add an export entry for hono in "package.json" file as well.

This is what I forgot but I fixed it quickly 😅

@ymc9
Copy link
Member

ymc9 commented Sep 30, 2024

@svetch , I think we need to add an export entry for hono in "package.json" file as well.

This is what I forgot but I fixed it quickly 😅

Awesome. Looks great now! I'll merge after the CI passes.

@ymc9 ymc9 merged commit b4418ac into zenstackhq:dev Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants