modules: hal_silabs: Add Proprietary TRX example #49

zohavas · 2023-12-15T16:04:09Z

Add Proprietary TRX example to show SiliconLabs radio board capabilities.

examples/proprietary_trx/src/main.c

examples/proprietary_trx/src/app_process.h

examples/proprietary_trx/src/app_rail.c

examples/proprietary_trx/src/app_cli.c

examples/proprietary_trx/src/app_rail.c

fkokosinski

Hi! Unfortunately the HAL repo is not the right place to add examples. We should add them in main Zephyr repo instead.

jerome-pouiller · 2024-01-08T13:07:41Z

Hi! Unfortunately the HAL repo is not the right place to add examples. We should add them in main Zephyr repo instead.

This exemple only work with Silabs specific API. I don't think it makes sense to place it in Zephyr repo, do you?

However, I believe it makes sense to publish it somewhere. Do you think it should be published on an external repository?

Note Espressif already publish examples with their HAL:
https://github.com/zephyrproject-rtos/hal_espressif/tree/zephyr/examples

fkokosinski · 2024-01-08T13:22:56Z

Note Espressif already publish examples with their HAL: https://github.com/zephyrproject-rtos/hal_espressif/tree/zephyr/examples

Hi! You're right indeed, and we should be fine with hosting these samples here in the SiLabs HAL then :) Thanks for pointing that out.

examples/proprietary_trx/CMakeLists.txt

examples/proprietary_trx/README.rst

examples/proprietary_trx/prj.conf

examples/proprietary_trx/src/app_rail.c

examples/proprietary_trx/src/app_rail.h

examples/proprietary_trx/src/config/rail/brd2601b/radio_settings.radioconf

examples/proprietary_trx/src/config/rail/brd2602a/radio_settings.radioconf

examples/proprietary_trx/CMakeLists.txt

jerome-pouiller · 2024-01-17T18:30:35Z

examples/proprietary_trx/src/main.c

+		}
+		if (s_obj.events & EVENT_RADIO_ERROR) {
+			smf_set_state(SMF_CTX(&s_obj), &radio_states[ERROR]);
+		}


I believe if two events raise in the same iteration, one of them will be ignored. The occurrence of the bug will depends of the execution time of the functions declared in radio_states.
BTW, if we miss the EVENT_RADIO_SENT event, we won't be able to send anything anymore.

examples/proprietary_trx/src/app_rail.h

examples/proprietary_trx/README.rst

examples/proprietary_trx/src/app_rail.c

examples/proprietary_trx/src/main.c

jerome-pouiller

Hello @zohavas.

Usually I tried to give all my comments in the two first version of a PR. Unfortunately, some of my comments are still related to code existing since the first version. I am sorry about that, I know it is not convenient.

examples/proprietary_trx/src/app_gpio.c

examples/proprietary_trx/src/app_rail.c

examples/proprietary_trx/src/main.c

examples/proprietary_trx/src/app_process.h

examples/proprietary_trx/src/main.c

examples/proprietary_trx/src/app_gpio.c

examples/proprietary_trx/README.rst

examples/proprietary_trx/src/app_cli.c

examples/proprietary_trx/src/app_gpio.c

examples/proprietary_trx/src/main.h

examples/proprietary_trx/src/autogen/sl_rail_util_init.c

examples/proprietary_trx/boards/efr32mg22_brd4182a.overlay

examples/proprietary_trx/src/app_gpio.c

examples/proprietary_trx/src/app_cli.c

jerome-pouiller

I am still dubious about the state machine, autogen files, etc... However, I don't see major issues we could fix without changing the whole design.

zohavas · 2024-02-01T10:18:01Z

@fkokosinski we are almost ready, we need to validate some things with our legal department. Please wait with the merge until we are ready, thank you.

Add Proprietary TRX example to show SiliconLabs radio board capabilities. Signed-off-by: Zoltan Havas <zoltan.havas@silabs.com>

zohavas · 2024-02-16T11:45:26Z

@fkokosinski thank you for waiting, we are ready with the requested legal validation, the merge can go, thank you for your help!

fkokosinski · 2024-02-20T08:10:33Z

@fkokosinski thank you for waiting, we are ready with the requested legal validation, the merge can go, thank you for your help!

Thanks for the ping. Please note that Zephyr is currently in a feature freeze, meaning we shouldn't be merging anything until it ends on February 23rd. I would also prefer to have 2 ACKs on the PR to Zephyr before moving with this to be sure that these changes will be pulled into Zephyr.

nordicjm

Samples should not be in hal repositories, this was never agreed with tsc

jhedberg

Samples should not be in hal repositories, this was never agreed with tsc

Indeed. I'm trying to find a suitable place where this could potentially land in the main tree, and the closest I've found so far would be under samples/boards there.

jhedberg · 2024-08-29T09:58:56Z

examples/proprietary_trx/README.rst

+
+.. code-block:: bash
+
+    west build -p always -b efr32bg22_brd4184a


This should IMO include two prior steps:

west update hal_silabs west blobs fetch hal_silabs

This introduce an example of use of Rail library in Zephyr. This is a reboot of PR[1]. Compared to the original PR, this version: - remove some files imported from Simplicity Studio. Only radio_config.[ch] are kept. - drop the useless Finite State Machine For now only two boards (based xg22 and xg24) are supported. I hope to add support for all the Series-2 boards in the future. Note Zephyr does not allow to host samples application in HALs. Samples specific to one board and using non-standard APIs are not very welcomed in the main repo. So, the Silabs downstream is probably the best (the only) place to provide publish it. [1]: zephyrproject-rtos/hal_silabs#49

This introduce an example of use of Rail library in Zephyr. This is a reboot of PR[1]. Compared to the original PR, this version: - remove some files imported from Simplicity Studio. Only radio_config.[ch] are kept. - drop the useless Finite State Machine For now only two boards (based xg22 and xg24) are supported. I hope to add support for all the Series-2 boards in the future. Note Zephyr does not allow to host samples application in HALs. Samples specific to one board and using non-standard APIs are not very welcomed in the main repo. So, the Silabs downstream is probably the best (the only) place to provide publish it. [1]: zephyrproject-rtos/hal_silabs#49 Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>

This introduce an example of use of Rail library in Zephyr. This is a reboot of PR[1]. Compared to the original PR, this version: - remove some files imported from Simplicity Studio. Only radio_config.[ch] are kept. - drop the useless Finite State Machine [1]: zephyrproject-rtos/hal_silabs#49 For now only two boards (based xg22 and xg24) are supported. I hope to add support for all the Series-2 boards in the future. Note Zephyr does not allow to host samples application in HALs. Samples specific to one board and using non-standard APIs are not very welcomed in the main repo. So, the Silabs downstream is probably the best (the only) place to provide publish it. Also note that files generated by Simplicity Studio (rail_config.*) ends lines with \r. To pass Zephyr compliance, this patch imports these files with \r removed: sed -i 's/\r//g' */rail_config.[hc] Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>

zephyrbot mentioned this pull request Dec 18, 2023

modules: hal_silabs: Add Proprietary TRX example zephyrproject-rtos/zephyr#66574

Closed

jerome-pouiller requested changes Dec 22, 2023

View reviewed changes

fkokosinski requested changes Jan 8, 2024

View reviewed changes

fkokosinski self-requested a review January 8, 2024 13:23

fkokosinski reviewed Jan 8, 2024

View reviewed changes

zohavas force-pushed the add_example_radio_trx branch 2 times, most recently from f9876a9 to 527d38d Compare January 16, 2024 11:07

zohavas requested review from fkokosinski and jerome-pouiller January 17, 2024 15:59

jerome-pouiller requested changes Jan 19, 2024

View reviewed changes

zohavas force-pushed the add_example_radio_trx branch 3 times, most recently from 5541cd5 to 576b290 Compare January 23, 2024 15:49

zohavas requested a review from jerome-pouiller January 23, 2024 15:51

zohavas force-pushed the add_example_radio_trx branch 3 times, most recently from 7463b7b to ee150d9 Compare January 29, 2024 14:32

jerome-pouiller requested changes Jan 29, 2024

View reviewed changes

zohavas force-pushed the add_example_radio_trx branch 2 times, most recently from 5cec2c7 to 34580b1 Compare January 29, 2024 16:42

jerome-pouiller requested changes Jan 29, 2024

View reviewed changes

zohavas force-pushed the add_example_radio_trx branch from 34580b1 to cfced72 Compare January 31, 2024 13:04

jerome-pouiller reviewed Jan 31, 2024

View reviewed changes

zohavas force-pushed the add_example_radio_trx branch 2 times, most recently from a0b3eaa to ac3b80a Compare February 1, 2024 09:43

jerome-pouiller approved these changes Feb 1, 2024

View reviewed changes

modules: hal_silabs: Add Proprietary TRX example

ebc2b4d

Add Proprietary TRX example to show SiliconLabs radio board capabilities. Signed-off-by: Zoltan Havas <zoltan.havas@silabs.com>

zohavas force-pushed the add_example_radio_trx branch from ac3b80a to ebc2b4d Compare February 16, 2024 11:38

nordicjm requested changes Aug 29, 2024

View reviewed changes

jhedberg requested changes Aug 29, 2024

View reviewed changes

jerome-pouiller mentioned this pull request Sep 19, 2024

samples: Introduce "simple_txrx" SiliconLabsSoftware/zephyr-silabs#42

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modules: hal_silabs: Add Proprietary TRX example #49

modules: hal_silabs: Add Proprietary TRX example #49

zohavas commented Dec 15, 2023

fkokosinski left a comment

jerome-pouiller commented Jan 8, 2024

fkokosinski commented Jan 8, 2024

jerome-pouiller Jan 17, 2024

jerome-pouiller left a comment

jerome-pouiller left a comment

zohavas commented Feb 1, 2024

zohavas commented Feb 16, 2024

fkokosinski commented Feb 20, 2024

nordicjm left a comment

jhedberg left a comment

jhedberg Aug 29, 2024


		.. code-block:: bash

		west build -p always -b efr32bg22_brd4184a

modules: hal_silabs: Add Proprietary TRX example #49

Are you sure you want to change the base?

modules: hal_silabs: Add Proprietary TRX example #49

Conversation

zohavas commented Dec 15, 2023

fkokosinski left a comment

Choose a reason for hiding this comment

jerome-pouiller commented Jan 8, 2024

fkokosinski commented Jan 8, 2024

jerome-pouiller Jan 17, 2024

Choose a reason for hiding this comment

jerome-pouiller left a comment

Choose a reason for hiding this comment

jerome-pouiller left a comment

Choose a reason for hiding this comment

zohavas commented Feb 1, 2024

zohavas commented Feb 16, 2024

fkokosinski commented Feb 20, 2024

nordicjm left a comment

Choose a reason for hiding this comment

jhedberg left a comment

Choose a reason for hiding this comment

jhedberg Aug 29, 2024

Choose a reason for hiding this comment