Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "scripts: serie_update: fetch submodules" #185

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Revert "scripts: serie_update: fetch submodules" #185

merged 1 commit into from
Dec 1, 2023

Conversation

ajarmouni-st
Copy link
Contributor

This reverts commit 818cef7.
Changes introduced in this commit (PR #182) are not enough to update Cube packages correctly following the introduction of submodules in the upstream STM32Cube repos.

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update commit message
with sign-off and explanation

This reverts commit 818cef7.
Changes introduced in 818cef7 (PR #182) are not enough to update
Cube packages correctly following the introduction of submodules in
the upstream STM32Cube GitHub repos. PR #184 gives a more effective
solution.

Signed-off-by: Abderrahmane Jarmouni <abderrahmane.jarmouni-ext@st.com>
@ajarmouni-st ajarmouni-st requested a review from erwango December 1, 2023 16:11
@erwango erwango merged commit f217494 into zephyrproject-rtos:main Dec 1, 2023
4 checks passed
@ajarmouni-st ajarmouni-st deleted the revert-182-dev_cube_update_c3.6.0 branch December 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants