-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lvgl 8.3.11 #47
Update lvgl 8.3.11 #47
Conversation
This commit introduced a regression in regards to background opacity behaviour when loading screens with FADE_ANIM for me:
|
Yesterday v8.3.11 was released. I added the respective new commits to this PR. So far I could not spot any regressions. |
Do we still need a |
Related to zephyrproject-rtos/lvgl#47 Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
Well we need a branch to merge to, are you proposing to ditch the repo entirely? Pretty sure we don't what that even if it follows upstream 1:1, it's useful to have anyway in case we want to diverge temporarily and converge back down the line. |
Not ditching, simply follow upstream 1:1, like we do for |
Ok so you mean: drop the |
Right, but now we have to keep adding merge commits simply for the |
Oh I see, yeah it'd make sense to use main, or maybe just tag it so git does not drop the refs and then force push it. Probably not worth it. |
fixes #4214
Signed-off-by: Nicușor Cîțu <nicusor.citu@nxp.com> Signed-off-by: Stefan Babatie <stefan.babatie@nxp.com> Signed-off-by: Jason Yu <zejiang.yu@nxp.com> Co-authored-by: Stefan Babatie <stefan.babatie@nxp.com> Co-authored-by: Jason Yu <zejiang.yu@nxp.com>
Co-authored-by: Oleg Belousov <bov@silentwings.ru>
Co-authored-by: Oleg Belousov <bov@silentwings.ru>
…l_value_fmt' (#4804)
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Co-authored-by: Rbb666 <64397326+Rbb666@users.noreply.github.com>
78cfad3
to
45b9c36
Compare
@pdgendt @fabiobaltieri Sure it would be doable to set up a branch which just tracks upstream. The differences between upstream and our fork mostly comes down to Kconfig changes. Btw. what I also found is that upstream LVGL also has zephyr Maybe we can sync our module file to upstream and have it be part of v9.0, so that we can eventually ditch the zephyr folder? |
Ideal. |
The module file is probably outdated if nobody cares to submit PRs. Maybe we can upstream already for v8? |
The project is currently finalizing v9 - I assume that there will not be another v8 release in the near future. Also one issue is that the |
Ping @fabiobaltieri @pdgendt do you maybe have an idea if its possible that the modules |
It looks like the location is hardcoded https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/zephyr_module.py#L179-L180 so with the current code base that is not possible, that said, it may be reasonable to expand the search path, maybe look for a |
@fabiobaltieri Thanks for your confirmation. 100% is not feasable since there are Kconfig defaults that we have set differently. I am content to have the merging strat etc. as is. I think that @pdgendt raised the question of tracking 1:1 originally. Anyways if there is feasable solution I'd love to hear it. This should not be a blocker for this update imo. |
If that's the only delta from upstream I think it may make sense to try and push to make the module file detection a bit smarter, but if we are going to have other patches on top of upstream anyway it's probably not worth the hassle IMO. |
|
Related to zephyrproject-rtos/lvgl#47 Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
Related to zephyrproject-rtos/lvgl#47 (cherry picked from commit 2a11c64) Original-Signed-off-by: Fabian Blatz <fabianblatz@gmail.com> GitOrigin-RevId: 2a11c64 Change-Id: I87c23131558fd25c34de77fcb26f44fdf292814a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5227908 Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com> Tested-by: Tristan Honscheid <honscheid@google.com> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Update LVGL module to version 8.3.11. Full release notes here:
CHANGELOG.md.
Substantial fixes: