Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversation-list-panel): filter archived conversations from search #2145

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 2, 2024

What does this do?

  • removes archived conversations from search results

Why are we making this change?

  • archived conversations should not appear when searching existing conversations

How do I test this?

  • run tests as usual.
  • run the ui and follow the steps outlined in demo below.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?
archived.mov

@domw30 domw30 requested a review from a team August 2, 2024 07:35
@domw30 domw30 merged commit 1380674 into main Aug 2, 2024
5 checks passed
@domw30 domw30 deleted the feat/filter-archived-conversations-from-search branch August 2, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant