Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(media-queries): remove min height on media queries #2288

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Sep 16, 2024

What does this do?

  • removes min height on media queries

Why are we making this change?

  • not required as causes issues by setting a min height, we don't need to be concerned with height

How do I test this?

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team September 16, 2024 13:58
Base automatically changed from feat/media-query-layout-large to main September 16, 2024 14:14
@domw30 domw30 merged commit 6801be3 into main Sep 16, 2024
5 checks passed
@domw30 domw30 deleted the refactor/improve-media-queries branch September 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant