Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(join-room-api): feature flag join room token gated chat api post #2417

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Nov 11, 2024

What does this do?

  • wraps the join room api post for token gated chat in a feature flag to disable for now

Why are we making this change?

  • as requested

How do I test this?

  • run tests as usual.
  • run ui and attempt to access a token gated chat - this should fail.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 merged commit 9504e50 into main Nov 11, 2024
5 checks passed
@domw30 domw30 deleted the refactor/disable-joining-room-tgc-api-call branch November 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant