Skip to content

Commit

Permalink
Don't redundantly redefine macOS architecture
Browse files Browse the repository at this point in the history
`CMAKE_OSX_ARCHITECTURES` is already set in `build.js`, so there's no need to set it in `binding.gyp`. In fact, if the architecture is inferred from the host (and not via the `$ARCH` env var), this previously resulted in incorrectly cross-compiling.
  • Loading branch information
rotu authored Jun 15, 2024
1 parent 828ed28 commit ee60d89
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,6 @@
],
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'GCC_ENABLE_EXCEPTIONS': 'YES',
'OTHER_CFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
],
'OTHER_LDFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
]
},
}],

Expand Down Expand Up @@ -227,12 +221,6 @@
'DEAD_CODE_STRIPPING': 'YES',
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'GCC_ENABLE_EXCEPTIONS': 'YES',
'OTHER_CFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
],
'OTHER_LDFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
]
},
}],

Expand Down

0 comments on commit ee60d89

Please sign in to comment.