Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login): comprehensive error handling #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(login): comprehensive error handling #181

wants to merge 1 commit into from

Conversation

dinxsh
Copy link
Contributor

@dinxsh dinxsh commented Oct 9, 2024 •
edited
Loading

What Type of Change is this?

  • New Feature
  • Fix
  • Improvement
  • Other

Description (required)

added error handling in the following sections in login.go

  1. Token validation
  2. Region
  3. User info

Related issues & labels (optional)

@dinxsh
Copy link
Contributor Author

dinxsh commented Oct 12, 2024

used i18n pkg this time

  • added errors to i18n.go
  • error messages in en.go

similar to the way its implemented in the rest of the code 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxck fxck Awaiting requested review from fxck

@l-hellmann l-hellmann Awaiting requested review from l-hellmann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Err Handlingzcli login
1 participant
@dinxsh