Feature/add backend graphql integration #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing was doing with TDD in mind, but also trying to understand the component life cycle. Goal here was to test the component without mocking the graphql client and provider Thoughts with mocks: * Codegen to add the types from Graphql backend is available, but no data. * No need to setup backend server to test with mocks * Render would respond immediately instead of waiting for async http requests * Coupled to backend with mocks * Easier to test but will draw a box around complete actual usage of the component Thoughts for calling backend: * Backend needs to be started for tests to run successfully * Required cross-fetch to polly fill jest tests not using actualy fetch api * Tests are slower for async rendering in tests * Understanding of render cycle and async testing in Jest and Testing React * Fitness test for frontend and server interaction * Testing backend compatability and changes * Test how the component is used for react life cycles * Might be able to test complete page without cypress. * Snapshot tests are more reliable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warpping the Apollo GraphQL Client Provider to use Context API hooks to manage graphql requests.
Type benefits.
Looks like it is restricted to 'use client' for now with Context API
Testing is possible with backend server and no mocking!