check if systemd is running before calling systemd commands #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for rpm based distros and linux mint in checks as well
glimberg
force-pushed
the
systemd-check
branch
from
f692e01
to
399ca3a
Compare
laduke
reviewed
Aug 29, 2024
| echo | ||
| exit 1 | ||
| exit 0 |
There was a problem hiding this comment.
If systemd isn't running, we don't want to call systemctl commands, or return an error.
|
sweeet |
laduke
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes installing on rpm containers that don't have systemd running possible without the script ending with a nonzero exit code.
Also adds checks for some rpm based distros, as well as linux mint in the tests