Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getNetworkName #25

Merged
merged 3 commits into from
Oct 16, 2023
Merged

feat: getNetworkName #25

merged 3 commits into from
Oct 16, 2023

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Oct 13, 2023

There is no standard for chain labels, so:

getNetworkName("mumbai_network") // => "mumbai_testnet"
getNetworkName("MuMbaI-tESTnet") // => "mumbai_testnet"

For example, viem, which is used by wagmi, which is used by Rainbow Kit calls Polygon Mumbai maticmum 🫠

We might make this smarter, by checking for -testnet and -network automatically, but we'll still have to keep wierd names like above.

@fadeev fadeev merged commit 4aedb41 into main Oct 16, 2023
4 checks passed
@fadeev fadeev deleted the get-network-name branch October 16, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants