[fix] fixed error "using Float as a String" when system locale using comma as float separator #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac OSX, phpstorm terminal vs system terminal
When LC_NUMERIC="C"
let s:goldenview__golden_ratio = 1.618
end with error using Float as a String
When i set LC_NUMERIC="pl_PL.UTF-8"
let s:goldenview__golden_ratio = 1.618
without problem.
After fix:
When LC_NUMERIC="C"
let l:golden_ratio_dot = str2float("1.618") /// 1
let l:golden_ratio_comma = str2float("1,618") /// 1,618
When LC_NUMERIC="pl_PL.UTF-8"
let l:golden_ratio_dot = str2float("1.618") /// 1.618
let l:golden_ratio_comma = str2float("1,618") /// 1
Then
let s:goldenview__golden_ratio = l:golden_ratio_xxxx
and both without errors.