Skip to content

Fix window drawing issues
Compare
Choose a tag to compare
@zhimsel zhimsel released this 03 Nov 18:46
· 18 commits to master since this release
1.0.2
74012d3
This commit was signed with the committer’s verified signature. The key has expired.
zhimsel Zach Himsel
GPG key ID: CA5B6466CFA962A5
Expired
Learn about vigilant mode.

This fixes window draw issues when compositing is enabled for un-evenly
divisible X-axis dimensions (e.g. for thirds or sixths). This script
will return a float to kwin, which X11 will balk at. When trying to
resize windows to non-integer dimensions, the window will fail to be
drawn correctly and can not be interacted with.

The patch described in this merge
request does
not appear to fix this particular issue, even though it should. I
tested using the Archlinux kwin package at
5.26.2.1-2
(which should include the patch; see below link), but the issue still
persisted.

So, instead, we can round our dimensions down to an integer before it's
even sent to kwin. This may be unnecessary in the future, if the
upstream bug is ever fixed, but it will not cause any harm except for an
undetectable waste of CPU cycles to floor() the dimensions.

Assets 3
Loading