Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard: Give style #3

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Leaderboard: Give style #3

merged 3 commits into from
Aug 31, 2023

Conversation

zhorabay
Copy link
Owner

  • In this branch, I:
  • set background picture;
  • changed font-family and font-colors;
  • made the scores list scrollable;
  • kept the general layout of the wireframe.

Copy link

@OLIPLICHE OLIPLICHE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhorabay,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • App is properly styled 👍
  • The App is working fine 👍

Required Changes ♻️

  • Hi, congratulations for making a great effort. Now, we need your Reame file to look more professional.
  • Can you provide the proper issue link?
  • Besides npm install, there is something there you need to clean up.
  • Add Run npm start bellow npm install to run the server,
  • Kindly pay attention to the red mark in the shot below to understand what I am talking about.

Capture
NB: These comments are not inline to the code because you did not make the code visible in this PR

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@Alfredbis29 Alfredbis29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED

Hi @zhorabay

Your project is complete! There is nothing else to say other than... Great job clap Congratulations! 🎉

TO HIGHLIGHT:

  • Your project is professional ✅
  • Good Job 👍

Now you can merge this branch and move on 1st_place_medal: HAPPY CODING AND GOOD LUCK WITH THE COMING ONES 🤞 :

Optional suggestions

  • Keep doing the Great work 🥂

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Alfredbis29 in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@zhorabay zhorabay merged commit 89b60d9 into dev Aug 31, 2023
5 checks passed
@zhorabay zhorabay deleted the styling-branch branch August 31, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants