-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.Target.Query: fix compilation error #21669
Conversation
Co-authored-by: Alex Rønne Petersen <alex@alexrp.com>
This isn't strictly related to this PR as it's just restoring existing behavior, but I don't understand why Android actually gets special-cased here. The idea seems to be that you can do |
@alexrp I added this a while back leaning towards a curated approach of non-native libc detection and so checks were added for the only 2 platforms I tested against: various apple SDKs and android NDK. Also this impl doesn't explicitly allow NDK on macos or windows hosts, and although rare, the NDKs are available. What I was happy about is that a garbage libc.txt was avoided. But if we take out In a better impl, what I'd like to see is some tech where an auto-generated To be clear, I think it is important to support exactly the use case pattern you listed (general cross compiler pathname) and it could very well be the curated approach is at odds with that goal. |
closes ziglang#21668 Co-authored-by: Alex Rønne Petersen <alex@alexrp.com>
closes #21668