std.io.tty: add getSize #22369
Open
std.io.tty: add getSize #22369
+46
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooster0
commented
Dec 31, 2024
wooster0
force-pushed
the
size
branch
3 times, most recently
from
e4539e4 to
2f9a873
Compare
std.Progress/the compiler already has and requires the code so you might as well make it available in general.
wooster0
commented
Dec 31, 2024
| return null; | ||
| } | ||
| } else { | ||
| var winsize: posix.winsize = .{ |
There was a problem hiding this comment.
In case someone knows: can't this just be initialized to undefined? Or are there cases where a field would not be written to by ioctl? If only in case of failure that wouldn't matter obviously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.Progress/the compiler already has and requires the code so you might as well make it available in general.
See also: #22021