AIP-8718 Allow disabling default cards; Allow card render failures #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general it looks good. I'm going to let Taleb decide to approve since he has experience with the repo. I like the use of try/except. EDIT: I see you had in your slack message a note that you need to add tests. |
cloudw
commented
Sep 3, 2024
talebzeghmi
reviewed
Sep 3, 2024
talebzeghmi
reviewed
Sep 26, 2024
talebzeghmi
approved these changes
Sep 27, 2024
| f"Failed to get cards from Metaflow backend for pathspec {pathspec}" | ||
| "Please view cards through Metaflow UI, or refer to https://docs.metaflow.org/metaflow/visualizing-results/effortless-task-inspection-with-default-cards#accessing-cards-via-an-api" | ||
| ) | ||
| continue |
There was a problem hiding this comment.
if we retry calling the metaflow metadata store, we should put a sleep in between retries, even a of 1s or 0.5 would make a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--add-default-cards false.Tests:
METAFLOW_AIP_ADD_DEFAULT_CARD="false": https://argo-server.int.stage-k8s.zg-aip.net/argo-ui/workflows/aip-example-dev/metadataflow-ssphxCloses AIP-8718