AIP-8651 Include parameters with no defaults in WorkflowTemplate #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudw
force-pushed
the
yunw/AIP-8651-include-all-params
branch
from
4ef1ef0
to
73521f2
Compare
cloudw
commented
Aug 24, 2024
|
|
||
| import boto3 | ||
| import pytest | ||
| from botocore.exceptions import ClientError |
talebzeghmi
requested changes
Sep 3, 2024
| for param in self.flow._get_parameters() | ||
| if param not in flow_parameters | ||
| ] | ||
| ) |
There was a problem hiding this comment.
this may not work:
File "/home/zservice/metaflow/metaflow/task.py", line 548, in run_step
self._exec_step_function(step_func)
File "/home/zservice/metaflow/metaflow/task.py", line 53, in _exec_step_function
step_function()
File "/home/zservice/metaflow/metaflow/plugins/aip/tests/flows/flow_triggering_flow.py", line 89, in start
self.submit_template(path)
File "/home/zservice/metaflow/metaflow/plugins/aip/tests/flows/flow_triggering_flow.py", line 198, in submit_template
subprocess.run(
File "/usr/local/lib/python3.9/subprocess.py", line 528, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['argo', 'template', '-n', 'metaflow-integration-testing-internal', 'create', '/tmp/wfdsk-ftf-test-argo-d64fe9ff-f1d7-4c7c-8551-c45c3c600063-0.yaml']' returned non-zero exit status 1.see:
There was a problem hiding this comment.
note: it'll also be important to ensure it's tested with a workflow compiled with an exit handler to ensure we don't hit argoproj/argo-workflows#6036
cloudw
force-pushed
the
yunw/AIP-8651-include-all-params
branch
from
afef70b
to
ab6a17f
Compare
cloudw
force-pushed
the
yunw/AIP-8651-include-all-params
branch
from
ab6a17f
to
0738816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters with no value is not valid for Workflows but are valid for WorkflowTemplate. Without being added to WorkflowTemplate, these parameter will not be accepted from Argo UI or sensors.