Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure ZnDraw connection #230

Merged
merged 76 commits into from
Oct 19, 2023
Merged

Secure ZnDraw connection #230

merged 76 commits into from
Oct 19, 2023

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Sep 23, 2023

this.socket.emit("modifier:run", {
name: "zndraw.modify.Delete",
params: {},
atoms: this.cache.get(this.world.getStep()),
selection: this.world.getSelection(),
step: this.world.getStep(),
points,
segments,
url: window.location.href,

Only submit:

  • name
  • params
  • step?

atoms, selection, segments, url can be retreived in other ways.

  • check that the scene loads succesfully
  • opening a window multiple times will duplicate the e.g. selection menu
  • local applications might not want to use a token, e.g. running it locally the uuid should maybe default to None / make CLI option.
  • selection / change frame could also be a message distributed to all other windows.

@PythonFZ PythonFZ linked an issue Sep 23, 2023 that may be closed by this pull request
1 task
@PythonFZ PythonFZ marked this pull request as draft September 23, 2023 09:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Merging #230 (f5d5f46) into main (33d1316) will decrease coverage by 7.42%.
The diff coverage is 27.25%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   48.75%   41.34%   -7.42%     
==========================================
  Files           7       13       +6     
  Lines         281     1028     +747     
==========================================
+ Hits          137      425     +288     
- Misses        144      603     +459     
Files Coverage Δ
tests/conftest.py 77.77% <80.00%> (-2.23%) ⬇️
zndraw/modify/__init__.py 43.44% <50.00%> (ø)
zndraw/settings.py 42.37% <50.00%> (ø)
zndraw/utils.py 31.25% <33.33%> (ø)
zndraw/analyse/__init__.py 26.66% <40.00%> (ø)
tests/test_zndraw.py 26.66% <26.66%> (ø)
zndraw/zndraw.py 28.37% <25.56%> (-2.45%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

PythonFZ and others added 25 commits October 2, 2023 21:50
PythonFZ and others added 25 commits October 19, 2023 08:57
@PythonFZ PythonFZ marked this pull request as ready for review October 19, 2023 12:03
@PythonFZ PythonFZ merged commit 97384e2 into main Oct 19, 2023
4 checks passed
@PythonFZ PythonFZ deleted the 200-secure-connection branch October 19, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure Connection
3 participants